Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest Asciidoctor gradle plugin #1202

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Update to latest Asciidoctor gradle plugin #1202

merged 1 commit into from
Oct 5, 2020

Conversation

deining
Copy link
Contributor

@deining deining commented Oct 4, 2020

This PR updates gradle Asciidoctor plugin to latest version.
After applying this PR, gradle ascii works again on master.

Unfortunately, now tabbed panes do not show up any more. :-(
Seems like the used extension is not picked up any more by the new version. I will look into that soon.
For now, the produced index.html is not ready for being published to the web site.

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2020

Codecov Report

Merging #1202 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1202   +/-   ##
=========================================
  Coverage     94.30%   94.30%           
  Complexity      455      455           
=========================================
  Files             2        2           
  Lines          6676     6676           
  Branches       1795     1795           
=========================================
  Hits           6296     6296           
  Misses          102      102           
  Partials        278      278           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2453cb4...eaaffa0. Read the comment docs.

@remkop
Copy link
Owner

remkop commented Oct 4, 2020

Would it not be easier to revert the last commit (2453cb4)?

@deining
Copy link
Contributor Author

deining commented Oct 5, 2020

Would it not be easier to revert the last commit (2453cb4)?

I force-pushed some changes for this PR, everything is working now:

  • gradle ascii runs successfully (using the latest version of the asciidoctor gradle plugin)
  • the produced manual file index.html now shows a tabbed source code pane, showing both the Java and the Kotlin version of the checksum app.

Please note that with the new version of the gradle plugin, html output is now written to build/docs (was: build/docs/html5). I don't know if this breaks your workflow when publishing documents. If so it could be easily corrected by adjusting the outputDir attribute of the asciidoctor task.

@remkop remkop merged commit 2a34abd into remkop:master Oct 5, 2020
@remkop remkop added this to the 4.6 milestone Oct 6, 2020
@remkop
Copy link
Owner

remkop commented Oct 6, 2020

Merged. Looks good!
One thing I noticed is that the Copy source function no longer works, but if we have to chose, they are both nice, but I think I like the tabbed examples feature better.

I should look into Groovy and Scala versions of the checksum example too, but at the moment too busy with other commitments...

remkop added a commit that referenced this pull request Oct 6, 2020
@deining
Copy link
Contributor Author

deining commented Oct 6, 2020

Merged. Looks good!
One thing I noticed is that the Copy source function no longer works, but if we have to chose, they are both nice, but I think I like the tabbed examples feature better.

Me too!

About the copy function: I realized already that the copy button is missing, but haven't found time to look into this. Using gradle 5.1, both the copybutton and the tabbed pane are working, so it can be done :-)

I should look into Groovy and Scala versions of the checksum example too, but at the moment too busy with other commitments...

If I remember correctly, there are files for that in the examples section already. I can take that over and will have a look soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants