Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source code highlighting for Kotlin, Scala and Groovy #1203

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Add source code highlighting for Kotlin, Scala and Groovy #1203

merged 1 commit into from
Oct 6, 2020

Conversation

deining
Copy link
Contributor

@deining deining commented Oct 5, 2020

This PR changes changes source highlighter to rouge since the current highlighter coderay does not support Kotlin and Scala.
This gives a better result for the listings in chapter 30 Picocli in Other Languages.

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2020

Codecov Report

Merging #1203 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1203   +/-   ##
=========================================
  Coverage     94.30%   94.30%           
  Complexity      455      455           
=========================================
  Files             2        2           
  Lines          6676     6676           
  Branches       1795     1795           
=========================================
  Hits           6296     6296           
  Misses          102      102           
  Partials        278      278           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2453cb4...36d5193. Read the comment docs.

@remkop
Copy link
Owner

remkop commented Oct 6, 2020

Merged. Thank you for the contribution!

@deining deining deleted the CodeHighlighting branch October 6, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants