Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual, section subcommands: add several tabs with Kotlin source code #1211

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Manual, section subcommands: add several tabs with Kotlin source code #1211

merged 1 commit into from
Oct 13, 2020

Conversation

deining
Copy link
Contributor

@deining deining commented Oct 13, 2020

Time permitting, I will add more tabs with source code. So don't worry if you don't find time to recreate the html page immediately.

@remkop remkop added this to the 4.6 milestone Oct 13, 2020
@remkop remkop merged commit c7e1dab into remkop:master Oct 13, 2020
@remkop
Copy link
Owner

remkop commented Oct 13, 2020

Merged. Thank you for the contribution!

remkop added a commit that referenced this pull request Oct 13, 2020
@remkop
Copy link
Owner

remkop commented Oct 13, 2020

The rendered HTML is also published now.

By the way, I noticed that the Kotlin highlighter has some trouble with things like

@Command(subcommands = [ A::class ]) // <--- notice the space between 'class' and `]` 
class X : Runnable

The space between 'class' and ] causes everything until 'X' to have red background.
Removing the space between ::class and the closing ] seems to fix it.
(Just FYI.)

@remkop
Copy link
Owner

remkop commented Oct 13, 2020

And thanks again for the contributions! Shaping up very nicely!

@deining deining deleted the kotlin branch October 14, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants