Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1366 point 1 (the help command arity) #1370

Merged
merged 3 commits into from Dec 1, 2021
Merged

Conversation

peutch
Copy link
Contributor

@peutch peutch commented Apr 30, 2021

Hi, I hope it is good enough.

@codecov
Copy link

codecov bot commented May 1, 2021

Codecov Report

Merging #1370 (25a39bb) into master (38909dc) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1370      +/-   ##
============================================
- Coverage     93.75%   93.75%   -0.01%     
  Complexity      474      474              
============================================
  Files             2        2              
  Lines          6968     6967       -1     
  Branches       1872     1872              
============================================
- Hits           6533     6532       -1     
  Misses          147      147              
  Partials        288      288              
Impacted Files Coverage Δ Complexity Δ
src/main/java/picocli/CommandLine.java 93.58% <100.00%> (-0.01%) 330.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38909dc...25a39bb. Read the comment docs.

Copy link
Owner

@remkop remkop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change, thank you for the pull request.
I would like to make a small change for backwards compatibility, can you take a look?

src/main/java/picocli/CommandLine.java Show resolved Hide resolved
@remkop remkop added this to the 4.6.2 milestone May 2, 2021
@remkop remkop added type: enhancement ✨ theme: usagehelp An issue or change related to the usage help message labels May 2, 2021
@remkop remkop modified the milestones: 4.6.2, 4.6.3 Nov 6, 2021
@remkop remkop linked an issue Dec 1, 2021 that may be closed by this pull request
@remkop remkop merged commit 4875e82 into remkop:master Dec 1, 2021
@remkop
Copy link
Owner

remkop commented Dec 1, 2021

Merged. Thank you for the contribution. Apologies for the delay.

(Note to self: TODO update release notes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: usagehelp An issue or change related to the usage help message type: enhancement ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

few points from a picocli beginner
2 participants