Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #1381 #1382

Merged
merged 2 commits into from Jun 8, 2021
Merged

fixes #1381 #1382

merged 2 commits into from Jun 8, 2021

Conversation

sfeuerhahn
Copy link
Contributor

This is an attempt to fix #1381 . It fixed my use case but I am not 100% sure if it raises other issues.

@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #1382 (3e0d721) into master (7f7889e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1382   +/-   ##
=========================================
  Coverage     93.75%   93.75%           
  Complexity      474      474           
=========================================
  Files             2        2           
  Lines          6968     6970    +2     
  Branches       1872     1872           
=========================================
+ Hits           6533     6535    +2     
  Misses          147      147           
  Partials        288      288           
Impacted Files Coverage Δ
src/main/java/picocli/CommandLine.java 93.58% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f7889e...3e0d721. Read the comment docs.

@remkop remkop added type: bug 🐛 theme: parser An issue or change related to the parser labels Jun 8, 2021
@remkop remkop added this to the 4.6.2 milestone Jun 8, 2021
@remkop remkop merged commit 7655278 into remkop:master Jun 8, 2021
remkop added a commit that referenced this pull request Jun 8, 2021
@remkop
Copy link
Owner

remkop commented Jun 8, 2021

Merged.
Thank you for the contribution!
This will be included in the next picocli release.

@sfeuerhahn
Copy link
Contributor Author

Thank you for this really great library!

MarkoMackic pushed a commit to MarkoMackic/picocli that referenced this pull request Oct 17, 2021
MarkoMackic added a commit to MarkoMackic/picocli that referenced this pull request Oct 17, 2021
MarkoMackic added a commit to MarkoMackic/picocli that referenced this pull request Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: parser An issue or change related to the parser type: bug 🐛
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default value of option in repeated subcommand not applied correctly
2 participants