Fix incorrect autocomplete if file name contains space #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remkop
added
theme: auto-completion
|
Thank you for another great contribution, @NewbieOrange ! |
remkop
added a commit
that referenced
this pull request
Nov 25, 2021
remkop
added a commit
that referenced
this pull request
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By setting the bash separator to
\n,COMPREPLYnow contains file names with spaces without splitting them, and can autocomplete correctly.After some preliminary testing, only files with line feed
\nin their name cannot be autocompleted correctly, butlsseem to behave the same, so looks good to me.This pull request will close #1458.