Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1526] Fix use of compinit clobbering existing completions #1548

Merged
merged 1 commit into from
Jan 17, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/java/picocli/AutoComplete.java
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,10 @@ private static class CommandDescriptor {
" alias compopt=complete\n" +
"\n" +
" # Enable bash completion in zsh (see [7])\n" +
" autoload -U +X compinit && compinit\n" +
" # Only initialize completions module once to avoid unregistering existing completions.\n" +
" if ! type compdef > /dev/null; then\n" +
" autoload -U +X compinit && compinit\n" +
" fi\n" +
" autoload -U +X bashcompinit && bashcompinit\n" +
"fi\n" +
"\n" +
Expand Down
20 changes: 16 additions & 4 deletions src/test/java/picocli/AutoCompleteTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -687,7 +687,10 @@ private String expectedCompletionScriptForAutoCompleteApp() {
" alias compopt=complete\n" +
"\n" +
" # Enable bash completion in zsh (see [7])\n" +
" autoload -U +X compinit && compinit\n" +
" # Only initialize completions module once to avoid unregistering existing completions.\n" +
" if ! type compdef > /dev/null; then\n" +
" autoload -U +X compinit && compinit\n" +
" fi\n" +
" autoload -U +X bashcompinit && bashcompinit\n" +
"fi\n" +
"\n" +
Expand Down Expand Up @@ -898,7 +901,10 @@ private String expectedCompletionScriptForNonDefault() {
" alias compopt=complete\n" +
"\n" +
" # Enable bash completion in zsh (see [7])\n" +
" autoload -U +X compinit && compinit\n" +
" # Only initialize completions module once to avoid unregistering existing completions.\n" +
" if ! type compdef > /dev/null; then\n" +
" autoload -U +X compinit && compinit\n" +
" fi\n" +
" autoload -U +X bashcompinit && bashcompinit\n" +
"fi\n" +
"\n" +
Expand Down Expand Up @@ -1457,7 +1463,10 @@ private String getCompletionScriptText(String cmdName) {
" alias compopt=complete\n" +
"\n" +
" # Enable bash completion in zsh (see [7])\n" +
" autoload -U +X compinit && compinit\n" +
" # Only initialize completions module once to avoid unregistering existing completions.\n" +
" if ! type compdef > /dev/null; then\n" +
" autoload -U +X compinit && compinit\n" +
" fi\n" +
" autoload -U +X bashcompinit && bashcompinit\n" +
"fi\n" +
"\n" +
Expand Down Expand Up @@ -1660,7 +1669,10 @@ private String getCompletionScriptTextWithHidden(String commandName) {
" alias compopt=complete\n" +
"\n" +
" # Enable bash completion in zsh (see [7])\n" +
" autoload -U +X compinit && compinit\n" +
" # Only initialize completions module once to avoid unregistering existing completions.\n" +
" if ! type compdef > /dev/null; then\n" +
" autoload -U +X compinit && compinit\n" +
" fi\n" +
" autoload -U +X bashcompinit && bashcompinit\n" +
"fi\n" +
"\n" +
Expand Down
5 changes: 4 additions & 1 deletion src/test/resources/bashify_completion.bash
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,10 @@ elif [ -n "$ZSH_VERSION" ]; then
alias compopt=complete

# Enable bash completion in zsh (see [7])
autoload -U +X compinit && compinit
# Only initialize completions module once to avoid unregistering existing completions.
if ! type compdef > /dev/null; then
autoload -U +X compinit && compinit
fi
autoload -U +X bashcompinit && bashcompinit
fi

Expand Down
5 changes: 4 additions & 1 deletion src/test/resources/basic.bash
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,10 @@ elif [ -n "$ZSH_VERSION" ]; then
alias compopt=complete

# Enable bash completion in zsh (see [7])
autoload -U +X compinit && compinit
# Only initialize completions module once to avoid unregistering existing completions.
if ! type compdef > /dev/null; then
autoload -U +X compinit && compinit
fi
autoload -U +X bashcompinit && bashcompinit
fi

Expand Down
5 changes: 4 additions & 1 deletion src/test/resources/hyphenated_completion.bash
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,10 @@ elif [ -n "$ZSH_VERSION" ]; then
alias compopt=complete

# Enable bash completion in zsh (see [7])
autoload -U +X compinit && compinit
# Only initialize completions module once to avoid unregistering existing completions.
if ! type compdef > /dev/null; then
autoload -U +X compinit && compinit
fi
autoload -U +X bashcompinit && bashcompinit
fi

Expand Down
5 changes: 4 additions & 1 deletion src/test/resources/picocompletion-demo-help_completion.bash
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,10 @@ elif [ -n "$ZSH_VERSION" ]; then
alias compopt=complete

# Enable bash completion in zsh (see [7])
autoload -U +X compinit && compinit
# Only initialize completions module once to avoid unregistering existing completions.
if ! type compdef > /dev/null; then
autoload -U +X compinit && compinit
fi
autoload -U +X bashcompinit && bashcompinit
fi

Expand Down
5 changes: 4 additions & 1 deletion src/test/resources/picocompletion-demo_completion.bash
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,10 @@ elif [ -n "$ZSH_VERSION" ]; then
alias compopt=complete

# Enable bash completion in zsh (see [7])
autoload -U +X compinit && compinit
# Only initialize completions module once to avoid unregistering existing completions.
if ! type compdef > /dev/null; then
autoload -U +X compinit && compinit
fi
autoload -U +X bashcompinit && bashcompinit
fi

Expand Down