Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing broken links and typos #1796

Merged
merged 2 commits into from
Sep 2, 2022
Merged

Fixing broken links and typos #1796

merged 2 commits into from
Sep 2, 2022

Conversation

deining
Copy link
Contributor

@deining deining commented Sep 1, 2022

This PR

  • fixes broken links (docu, javadocs)
  • fixes several typos
  • updates asciidoctorj to latest version 2.5.5.

@remkop remkop added this to the 4.7 milestone Sep 2, 2022
@remkop remkop merged commit 30c88e9 into remkop:main Sep 2, 2022
@remkop
Copy link
Owner

remkop commented Sep 2, 2022

Thank you @deining !! 🙏
Much appreciated!

(It is unfortunate that the GraalVM documentation now seems tightly coupled to a version number... :-(
Actually, looking closer now, it seems that generic URLs without version number are automatically redirected to the latest version...

If I open https://www.graalvm.org/reference-manual/native-image/basics/ in my browser,
it is redirected to
https://www.graalvm.org/22.2/reference-manual/native-image/basics/

Perhaps it is better to remove the version number from the URLs in the picocli docs and rely on the GraalVM site to redirect to the latest version. What do you think?

remkop added a commit that referenced this pull request Sep 2, 2022
@deining
Copy link
Contributor Author

deining commented Nov 26, 2022

If I open https://www.graalvm.org/reference-manual/native-image/basics/ in my browser, it is redirected to https://www.graalvm.org/22.2/reference-manual/native-image/basics/

Perhaps it is better to remove the version number from the URLs in the picocli docs and rely on the GraalVM site to redirect to the latest version. What do you think?

Good idea, done with #1881.

@deining deining deleted the contribution branch November 26, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants