Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using boxed boolean in applyValueToSingleValuedField #1911

Merged
merged 1 commit into from Jan 7, 2023
Merged

Avoid using boxed boolean in applyValueToSingleValuedField #1911

merged 1 commit into from Jan 7, 2023

Conversation

Jiehong
Copy link
Contributor

@Jiehong Jiehong commented Jan 5, 2023

booleanValue returns a boolean, so no need to box it into a Boolean

@remkop remkop added this to the 4.7.1 milestone Jan 6, 2023
@Jiehong
Copy link
Contributor Author

Jiehong commented Jan 6, 2023

automatic checks failures aren't related to the change in this PR at all.

@remkop
Copy link
Owner

remkop commented Jan 7, 2023

automatic checks failures aren't related to the change in this PR at all.

Yes, sorry, I approved and meant to merge it but I got distracted and forgot that I hadn't merged this yet. 😅

@remkop remkop merged commit 907e1c0 into remkop:main Jan 7, 2023
@Jiehong Jiehong deleted the bugfix/native_bool branch January 7, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remkop remkop remkop approved these changes

Assignees
No one assigned
Labels
type: enhancement ✨
Projects
None yet
Milestone
4.7.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jiehong @remkop