Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Java 5 and 6 JVMs #214

Merged
merged 1 commit into from Oct 25, 2017
Merged

Fix for Java 5 and 6 JVMs #214

merged 1 commit into from Oct 25, 2017

Conversation

sjsajj
Copy link
Contributor

@sjsajj sjsajj commented Oct 24, 2017

Fixing the dependency on Java 7 by removing the java.util.Objects.requireNonNull calls.
The project will now be able to run on Java 5 JVMs again.

…uireNonNull calls.

The project will now be able to run on Java 5 JVMs again.
@codecov-io
Copy link

Codecov Report

Merging #214 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #214   +/-   ##
=========================================
  Coverage     86.62%   86.62%           
  Complexity      148      148           
=========================================
  Files             4        4           
  Lines          1839     1839           
  Branches        460      460           
=========================================
  Hits           1593     1593           
  Misses          126      126           
  Partials        120      120
Impacted Files Coverage Δ Complexity Δ
src/main/java/picocli/CommandLine.java 89.07% <50%> (ø) 87 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9619885...f3ce178. Read the comment docs.

@remkop
Copy link
Owner

remkop commented Oct 24, 2017

Good catch, thank you!

@remkop
Copy link
Owner

remkop commented Oct 24, 2017

The codecov plugin prevents me from merging this on my phone. (Unsure why, looks like a codecov bug.)
I’ll merge this when I get back to my pc tonight.

@remkop remkop merged commit 5b0c355 into remkop:master Oct 25, 2017
@remkop remkop added this to the 2.0.1 milestone Oct 25, 2017
@remkop
Copy link
Owner

remkop commented Oct 25, 2017

This has been merged into master, and a new release (v2.0.1) is now available from Maven Central and JCentral.

Thanks again for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants