Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jansi auto detection. #486

Merged
merged 2 commits into from
Sep 20, 2018
Merged

Add Jansi auto detection. #486

merged 2 commits into from
Sep 20, 2018

Conversation

charphi
Copy link
Contributor

@charphi charphi commented Sep 17, 2018

See #483

@remkop
Copy link
Owner

remkop commented Sep 17, 2018

Looks good!
Do you think you can add a unit test for this?

@codecov-io
Copy link

codecov-io commented Sep 19, 2018

Codecov Report

Merging #486 into master will decrease coverage by 0.06%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #486      +/-   ##
============================================
- Coverage     89.15%   89.09%   -0.07%     
  Complexity      281      281              
============================================
  Files             4        4              
  Lines          3846     3851       +5     
  Branches        931      932       +1     
============================================
+ Hits           3429     3431       +2     
- Misses          207      209       +2     
- Partials        210      211       +1
Impacted Files Coverage Δ Complexity Δ
src/main/java/picocli/CommandLine.java 89.06% <33.33%> (-0.08%) 153 <0> (ø)
src/main/java/picocli/AutoComplete.java 86.55% <0%> (ø) 80% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac91f44...3dd267b. Read the comment docs.

@charphi
Copy link
Contributor Author

charphi commented Sep 19, 2018

I've added a test but it doesn't increase the code coverage.
I don't know how to properly test this since it depends on runtime context.

@remkop
Copy link
Owner

remkop commented Sep 20, 2018

@charphi Sorry for my late response. Thanks for adding a test! I'll try to take a closer look later today.

@remkop remkop merged commit 8c4a8fd into remkop:master Sep 20, 2018
@remkop remkop mentioned this pull request Sep 20, 2018
@remkop remkop added this to the 3.6.1 milestone Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants