Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print help infinite loop fix #547

Merged
merged 2 commits into from
Nov 12, 2018
Merged

Print help infinite loop fix #547

merged 2 commits into from
Nov 12, 2018

Conversation

patrickkuo
Copy link

Print help run into infinite loop when length of the text equals to columnValue.maxLength and offset is non zero.

@codecov-io
Copy link

codecov-io commented Nov 12, 2018

Codecov Report

Merging #547 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #547   +/-   ##
=========================================
  Coverage     89.17%   89.17%           
  Complexity      285      285           
=========================================
  Files             4        4           
  Lines          3946     3946           
  Branches        967      967           
=========================================
  Hits           3519     3519           
  Misses          213      213           
  Partials        214      214
Impacted Files Coverage Δ Complexity Δ
src/main/java/picocli/CommandLine.java 89.21% <100%> (ø) 160 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea51553...a3b8bac. Read the comment docs.

@remkop remkop merged commit 2a8db2a into remkop:master Nov 12, 2018
@remkop remkop added this to the 3.8 milestone Nov 12, 2018
@remkop
Copy link
Owner

remkop commented Nov 12, 2018

Merged.
Good catch! Thank you very much!

remkop added a commit that referenced this pull request Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants