Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JLine3 example: use defaultParser to split readLine output #587

Merged
merged 1 commit into from
Jan 3, 2019

Conversation

mattirn
Copy link
Contributor

@mattirn mattirn commented Jan 3, 2019

Use defaultParser to split readLine output in order to manage correctly escaped chars and quoted arguments

@codecov-io
Copy link

Codecov Report

Merging #587 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #587   +/-   ##
=========================================
  Coverage     98.09%   98.09%           
  Complexity      350      350           
=========================================
  Files             4        4           
  Lines          4092     4092           
  Branches       1005     1005           
=========================================
  Hits           4014     4014           
  Misses           23       23           
  Partials         55       55

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eca9e6c...cd68cd3. Read the comment docs.

@remkop remkop added this to the 3.9 milestone Jan 3, 2019
@remkop remkop added type: enhancement ✨ theme: auto-completion An issue or change related to auto-completion theme: shell An issue or change related to interactive (JLine) applications labels Jan 3, 2019
@remkop remkop merged commit 8347846 into remkop:master Jan 3, 2019
@remkop
Copy link
Owner

remkop commented Jan 3, 2019

Nice one!
This has been merged and will be included in the upcoming 3.9 release.
Thank you for the contribution!

remkop added a commit that referenced this pull request Jan 3, 2019
@mattirn mattirn deleted the jline3a branch January 6, 2019 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: auto-completion An issue or change related to auto-completion theme: shell An issue or change related to interactive (JLine) applications type: enhancement ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants