Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically split lines in TextTable #696 #741

Merged
merged 5 commits into from Jun 21, 2019
Merged

Automatically split lines in TextTable #696 #741

merged 5 commits into from Jun 21, 2019

Conversation

sualeh
Copy link
Contributor

@sualeh sualeh commented Jun 20, 2019

Automatically split lines in TextTable

@codecov-io
Copy link

codecov-io commented Jun 20, 2019

Codecov Report

Merging #741 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #741      +/-   ##
============================================
+ Coverage     93.19%   93.21%   +0.01%     
  Complexity      370      370              
============================================
  Files             2        2              
  Lines          5572     5586      +14     
  Branches       1450     1455       +5     
============================================
+ Hits           5193     5207      +14     
  Misses          183      183              
  Partials        196      196
Impacted Files Coverage Δ Complexity Δ
src/main/java/picocli/CommandLine.java 92.89% <100%> (+0.01%) 255 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d67b775...3c9a6b4. Read the comment docs.

@remkop remkop added this to the 4.0 milestone Jun 20, 2019
Copy link
Owner

@remkop remkop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the PR!
I put some comments with requests for minor changes, but this looks nearly ready to merge. Thank you!

src/main/java/picocli/CommandLine.java Outdated Show resolved Hide resolved
src/main/java/picocli/CommandLine.java Outdated Show resolved Hide resolved
src/main/java/picocli/CommandLine.java Outdated Show resolved Hide resolved
@sualeh
Copy link
Contributor Author

sualeh commented Jun 21, 2019

@remkop - should be ready to merge now.

@remkop remkop merged commit 227669d into remkop:master Jun 21, 2019
@remkop
Copy link
Owner

remkop commented Jun 21, 2019

Merged.
I’ll update the release notes later.
Thank you for the contribution!
#696

@sualeh sualeh deleted the issue696 branch June 21, 2019 03:41
remkop added a commit that referenced this pull request Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants