Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lifetime conflict #11

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Fix lifetime conflict #11

merged 2 commits into from
Feb 13, 2024

Conversation

jmoore34
Copy link

Fixes #10

remkop22
remkop22 requested changes Feb 13, 2024
View reviewed changes
Copy link
Owner

@remkop22 remkop22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! thanks a lot for fixing this.

Maybe we should go with a (uglier) name that we are confident will never conflict with a user's lifetime?

Something like '__from_row_lifetime?

@jmoore34
Copy link
Author

Updated the lifetime name

remkop22
remkop22 approved these changes Feb 13, 2024
View reviewed changes
Copy link
Owner

@remkop22 remkop22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@remkop22 remkop22 merged commit dd5bf6a into remkop22:master Feb 13, 2024
@jmoore34 jmoore34 mentioned this pull request Feb 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remkop22 remkop22 remkop22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fails to compile when 'a lifetime parameter used
2 participants
@jmoore34 @remkop22