Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmorization module #20

Merged
merged 6 commits into from
Nov 7, 2021
Merged

Cmorization module #20

merged 6 commits into from
Nov 7, 2021

Conversation

larsbuntemeyer
Copy link
Contributor

updates for cmorization module

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2021

Codecov Report

Merging #20 (96b8fac) into master (ac94c3d) will decrease coverage by 0.01%.
The diff coverage is 25.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
- Coverage   23.33%   23.31%   -0.02%     
==========================================
  Files          28       28              
  Lines        1620     1677      +57     
==========================================
+ Hits          378      391      +13     
- Misses       1242     1286      +44     
Flag Coverage Δ
unittests 23.31% <25.30%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyremo/cmor/remo_cmor.py 24.39% <24.39%> (ø)
pyremo/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e31f14...96b8fac. Read the comment docs.

@larsbuntemeyer larsbuntemeyer marked this pull request as ready for review November 7, 2021 00:42
@larsbuntemeyer larsbuntemeyer merged commit d1e881b into master Nov 7, 2021
@larsbuntemeyer
Copy link
Contributor Author

@ludwiglierhammer i cleaned and included your code into pyremo.cmor and also included the experimental cordex cmor tables into py-cordex (euro-cordex/py-cordex#27). You would have to use the py-cordex master branch because it's only coming with the next release...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants