Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmor updates #48

Merged
merged 8 commits into from
Apr 6, 2022
Merged

cmor updates #48

merged 8 commits into from
Apr 6, 2022

Conversation

larsbuntemeyer
Copy link
Contributor

@larsbuntemeyer larsbuntemeyer commented Apr 5, 2022

Updates to use CMIP6 cmor tables with CORDEX controlled vocabulary. This means we can use all of the original CMIP6 cmor tables simply by including our missing model and institutes to the controlled vocabulary table.

closes #50

@codecov-commenter
Copy link

Codecov Report

Merging #48 (72ae0bf) into master (b0770ae) will decrease coverage by 0.33%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   37.79%   37.46%   -0.34%     
==========================================
  Files          29       29              
  Lines        1323     1332       +9     
==========================================
- Hits          500      499       -1     
- Misses        823      833      +10     
Flag Coverage Δ
unittests 37.46% <80.00%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyremo/cmor/utils.py 82.50% <66.66%> (-1.72%) ⬇️
pyremo/cmor/remo_cmor.py 62.79% <80.00%> (-3.88%) ⬇️
pyremo/core/domain.py 55.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0770ae...72ae0bf. Read the comment docs.

@larsbuntemeyer larsbuntemeyer marked this pull request as ready for review April 6, 2022 13:49
@larsbuntemeyer larsbuntemeyer merged commit 89275a4 into master Apr 6, 2022
@larsbuntemeyer larsbuntemeyer deleted the cmor-updates branch April 6, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

longitude and latitude in cmorized output have nan
2 participants