Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prsint command line interface #53

Merged
merged 12 commits into from
Apr 25, 2022
Merged

prsint command line interface #53

merged 12 commits into from
Apr 25, 2022

Conversation

larsbuntemeyer
Copy link
Contributor

@larsbuntemeyer larsbuntemeyer commented Apr 23, 2022

This pr will add a command line interface prsint so the pressure interpolation can be done on files from the command line.

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2022

Codecov Report

Merging #53 (737ff5e) into master (2be4706) will decrease coverage by 3.47%.
The diff coverage is 7.89%.

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   57.94%   54.47%   -3.48%     
==========================================
  Files          23       25       +2     
  Lines         944     1006      +62     
==========================================
+ Hits          547      548       +1     
- Misses        397      458      +61     
Flag Coverage Δ
unittests 54.47% <7.89%> (-3.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyremo/cli.py 0.00% <0.00%> (ø)
pyremo/prsint/_defaults.py 0.00% <0.00%> (-100.00%) ⬇️
pyremo/prsint/cli.py 0.00% <0.00%> (ø)
pyremo/core/utilities.py 18.18% <18.18%> (ø)
pyremo/prsint/core.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2be4706...737ff5e. Read the comment docs.

@larsbuntemeyer
Copy link
Contributor Author

larsbuntemeyer commented Apr 25, 2022

should we click for (testing) the command line interface?

@larsbuntemeyer larsbuntemeyer marked this pull request as ready for review April 25, 2022 14:55
@larsbuntemeyer
Copy link
Contributor Author

should we click for (testing) the command line interface?

we stay with argparse for now, the cli is quite simple and it works for now.

@larsbuntemeyer larsbuntemeyer merged commit 9843918 into master Apr 25, 2022
@larsbuntemeyer larsbuntemeyer deleted the prsint-cli branch April 25, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants