Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linting #55

Merged
merged 13 commits into from
Apr 26, 2022
Merged

linting #55

merged 13 commits into from
Apr 26, 2022

Conversation

larsbuntemeyer
Copy link
Contributor

@larsbuntemeyer larsbuntemeyer commented Apr 25, 2022

This PR does a lot of format changes to get linting right. We now try to stick to flake8 and black code formatting.

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2022

Codecov Report

Merging #55 (1e7dd40) into master (9843918) will increase coverage by 0.10%.
The diff coverage is 35.60%.

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   54.47%   54.58%   +0.10%     
==========================================
  Files          25       25              
  Lines        1006      993      -13     
==========================================
- Hits          548      542       -6     
+ Misses        458      451       -7     
Flag Coverage Δ
unittests 54.58% <35.60%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyremo/cli.py 0.00% <0.00%> (ø)
pyremo/cmor/derived.py 38.80% <ø> (-0.90%) ⬇️
pyremo/core/utilities.py 0.00% <ø> (-18.19%) ⬇️
pyremo/physics/core.py 41.17% <ø> (ø)
pyremo/physics/units.py 0.00% <ø> (ø)
pyremo/prsint/cli.py 0.00% <0.00%> (ø)
pyremo/tables/__init__.py 100.00% <ø> (ø)
pyremo/tables/_resources.py 86.95% <ø> (ø)
pyremo/tutorial.py 64.70% <ø> (ø)
pyremo/core/domain.py 55.00% <50.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9843918...1e7dd40. Read the comment docs.

@larsbuntemeyer larsbuntemeyer changed the title Pre commit linting Apr 26, 2022
@larsbuntemeyer larsbuntemeyer marked this pull request as ready for review April 26, 2022 08:36
@larsbuntemeyer larsbuntemeyer merged commit dfc6625 into master Apr 26, 2022
@larsbuntemeyer larsbuntemeyer deleted the pre-commit branch April 26, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants