Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remoteworks.jp static website πŸŽ‰ #100

Merged
merged 66 commits into from Feb 20, 2020
Merged

Conversation

SaulSilver
Copy link
Contributor

@SaulSilver SaulSilver commented Feb 19, 2020

Fixes #31

Website

Live demo on Netlify: https://remoteworks.netlify.com/

  • Static website using Jekyll according to @yasulab suggestion (Github Pages to be added after merge)
  • Multilingual; Japanese πŸ‡―πŸ‡΅and English πŸ‡ΊπŸ‡Έ
  • Supports tags like Fully remote and Japanese required
  • Search input to search job posts
  • Made a simple logo (favicon) for the website. Just realized now it looks a bit like Rakuten's πŸ€¦β€β™‚οΈ

Structure

This part will be added to the README once the PR is merged.

For the website to support multilingual, the structure is as following.

_includes/
_layouts/
en/
  _posts/
    2020-02-19-hi.md
  index.md
ja/
  _posts/
    2020-02-19-konnichwa.md
  index.md
public/
_config.yml

Each job post is 2 files (en & ja). My reasoning is, one file containing all the job posts is already becoming too big and long to scroll through. Also, with this structure, we can add more info per job post since each post has its own page too.

To note

There are some things to keep in mind to change later

  1. The tag Japanese required is irrelevant for the website in Japanese.
  2. Add tag for English-friendly as specified in issue Make it clear where Japanese language ability is required.Β #99.
  3. I've added the first 2 jobs posts only to show it as an example, we'll need to migrate all the rest to separate files.
  4. Add missing Japanese translations of the website.
  5. Search field searches all posts (English & Japanese of the same post). It should search for unique files relevant to the language at best.

Resources

@yasulab
Copy link
Member

yasulab commented Feb 19, 2020

Thanks for your PR!! I'll look into this PR later. πŸ‘€ πŸ’¨ ✨ (And #100th contribution! πŸŽ‰πŸ’–)

Copy link
Member

@yasulab yasulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have locally checked and I think it is great as a starting point! πŸ˜»πŸ†’βœ¨ There may be some points to improve like typo (s/Github/GitHub/g in footer) but I think we can do it later and not necessary in a starting point. πŸ‘€ πŸ’­

image

@uiur If you think okay, can you merge this PR and fill in Custom domain with remotework.jp from Settings page? (It's because I don't have privilege to access Settings page yet. 😹 Or, if I get the privilege of this repo then I can set it up by myself. πŸ˜‰)

cf. https://help.github.com/en/github/working-with-github-pages/managing-a-custom-domain-for-your-github-pages-site#configuring-an-apex-domain

I have set up DNS and remotework.jp is already pointing to GitHub Pages. πŸ› βœ… (https is not available yet. It can be configured from Settings page as well)

image

@SaulSilver
Copy link
Contributor Author

@yasulab thanks for pointing out the typo and clarifying it. I've fixed the typo ✌️

README.md Outdated Show resolved Hide resolved
@uiur
Copy link
Collaborator

uiur commented Feb 20, 2020

looks good to me
I'll merge when #100 (comment) is fixed

@SaulSilver
Copy link
Contributor Author

@uiur thanks for the review. Did what you suggested.

@SaulSilver SaulSilver requested a review from uiur February 20, 2020 10:44
@uiur uiur merged commit 55b87a1 into remote-jp:master Feb 20, 2020
@uiur
Copy link
Collaborator

uiur commented Feb 20, 2020

πŸš€πŸ’₯ https://remotework.jp/

@uiur
Copy link
Collaborator

uiur commented Feb 20, 2020

moved code into docs/ #102

@yasulab
Copy link
Member

yasulab commented Feb 21, 2020

Nice! d( ̄  ̄)✨

I will update some gems and copy data from README to /docs to show companies from remotework.jp (manually for now, will be automated later).

@SaulSilver
Copy link
Contributor Author

Thank you! ✌️I’m busy this weekend but will add next week if any left. 🧼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Domain Sponsorship: remotework.jp
4 participants