-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Deleted files or folders resurrected #611
Comments
are you doing some operations concurrently on the same folder on the multiple devices? 且可以用中文反馈 |
在这些情况发生的时候没有同时操作同一个文件, 但是之前有过好奇尝试两个设备同时修改同一个其他的markdown文件, 结果就是一个文件把另一个文件覆盖了,没有出现任何错误 还有就是删除单个文件的时候有的时候会成功 |
我也没有两边都操作更新 |
I suspect it has something to do with links. I got the feeling that files that are linked alot are more likely to be recreated. But it doesn't really make sense to me. There are still only an erased file. Both the correct and the dobble one are pointing to correct files. |
Please consider report the sync plans on each device. I suspect you still update something on one device. |
You mean that obsidian are still working on something simultaneously with the sync? |
That has happened as well. To get around it, I moved a few files at a time
and it worked on device Y. However, it did not work later on device Z.
Den ons 1 maj 2024 19:55JK2333 ***@***.***> skrev:
…
我也出现了类似的情况。我在PC上移动了文件,将它从文件夹A到B文件夹内,结果今天Ipad同步发现所有的文件全部又恢复到A文件夹中了。我去查看存储桶发现已经被全部同步上去了。
我的设备是Window11,Ipados 17.4.1
image.png (view on web)
<https://github.com/remotely-save/remotely-save/assets/51532948/1ed67232-db05-4969-a345-65b8ab87ed20>
—
Reply to this email directly, view it on GitHub
<#611 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BEN5HFJJIW6HMLIVMVAKJQLZAEUAPAVCNFSM6AAAAABGLHJUIWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBYHA2DEOBWGM>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
may i ask anyone reproduce the error using a new, only installing remotely save, test vault and then upload sync plans? remember to remove any sensitive personal info |
The problem seems to be with the "Deletion Destination". When it's set to "system default (default)", it works, but when set to "Obsidian .trash folder", the files are NOT moved from the corresponding disk folder, and I suppose the RS-sync just reads them back. See my attached PDF with screenshots. |
现在多端更新简直是灾难,删除了文件还会出现,移动了文件又会重新生成到移动前的位置 |
Quick temporary fix is to set the removed file setting to default!
Den sön 5 maj 2024 18:15JK2333 ***@***.***> skrev:
… 现在多端更新简直是灾难,删除了文件还会出现,移动了文件又会重新生成到移动前的位置
—
Reply to this email directly, view it on GitHub
<#611 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BEN5HFKIQLAFJRRCWV3WRRDZAZLLTAVCNFSM6AAAAABGLHJUIWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJUHA3DKMJTGU>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
I always set it to the default value, which doesn't seem to be the cause of the bug.
|
I've tested this several times and found that deleting a file on Mac/window doesn't remove the same file on the Ipad, and then a certain sync will sync the ipad's wrong file up again so that the version goes back down again. |
are you using auto sync? after deleting a file on windows has the deletion synced on remote (eg. onedrive website)? |
It's strange that the Obsidan didn't move the files on the A client when I
remove them. An obsidan bug? The removed file setting in RS should not
really makes a different on the A client. Only on the B client when files
has been synced as removed.
Den sön 5 maj 2024 18:32JK2333 ***@***.***> skrev:
… I always set it to the default value, which doesn't seem to be the cause
of the bug.
Quick temporary fix is to set the removed file setting to default! Den sön
5 maj 2024 18:15JK2333 *@*.***> skrev:
快速临时修复是将已删除的文件设置设置为默认值!
2024 年 5 月 5 日 18:15JK2333 *@*.
*> skrev: … <#m_1509537774644188110_>
现在多端更新简直是灾难,删除了文件还会出现,移动了文件又会重新生成到移动前的位置 — Reply to this email directly,
view it on GitHub <#611 (comment)
<#611 (comment)>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BEN5HFKIQLAFJRRCWV3WRRDZAZLLTAVCNFSM6AAAAABGLHJUIWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJUHA3DKMJTGU
<https://github.com/notifications/unsubscribe-auth/BEN5HFKIQLAFJRRCWV3WRRDZAZLLTAVCNFSM6AAAAABGLHJUIWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJUHA3DKMJTGU>
. You are receiving this because you commented.Message ID: @.*>
—
Reply to this email directly, view it on GitHub
<#611 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BEN5HFO54ZCVETNPME455FDZAZNIXAVCNFSM6AAAAABGLHJUIWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJUHA3DSNJRGM>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
@nallebrean @2019YKL @Barmaid1076 @seyeeL Don't need to guess. Please follow the steps precisely, and see any step doesn't return the same result as my description. Please, really precisely, do not do anything more or less.
不需要猜测。请完全按照以下步骤操作,看看哪一步操作结果和我的描述不一样。请注意,完全按照,不要做多了,不要做少了。
|
Sorry but what will "Server Address" be for infinicloud? |
是的,我测试也是如此,删除文件在iPhone和iPad表现不稳定,有时候能正常删除,有时候无法正常删除。 |
删除文件之前,mac和ipad已经进行了完全一致同步了吗?也就是说,那时候之前,mac,ipad,s3 三方是完全一致,内容一致,修改时间一致吗?这是先决条件啊
ipad 上导出同步计划然后看看你马赛克的那些被重新上传的文件的信息?是一个大的json片段。可以改掉json内的实际文件名。
为啥呢,新建一个 vault 会有什么成本? |
@nallebrean please refer to the screenshot here https://github.com/remotely-save/remotely-save/tree/master/docs/remote_services/webdav_infinicloud_teracloud |
是的,所以新建测试 vault 来进行
唉,这里真的,完全按照我的步骤来操作,是否可以呢?关键在于,有welcome文件的情况下,新建文件夹和里面的文件,然后做同步和删除。 如果只有一份 welcome 文件,你删除了,本地会变成空库,那么会走到特殊逻辑把远程的文件重新下载,这不是 bug,也和本群的问题无关。 |
@2019YKL 精确按照这里操作,除了 webdav 换成 s3 之外,其他步骤精确按照每一步进行,看有没有问题。求求了,不这样精确按照步骤进行测试的话,我们都是在浪费时间,查不出来的。 |
My created test note on windows will be created in the vaults root and not
in the testdir1. I have to move it unless I change settings in Obsidan.
Does it matter?
Den mån 6 maj 2024 12:11fyears ***@***.***> skrev:
… @nallebrean <https://github.com/nallebrean> @2019YKL
<https://github.com/2019YKL> @Barmaid1076 <https://github.com/Barmaid1076>
@seyeeL <https://github.com/seyeeL>
------------------------------
Don't need to guess. Please follow the steps *precisely*, and see any
step doesn't return the same result as my description. Please, really
*precisely*, do not do anything more or less.
1.
Windows
1.
On Windows, create new vault naming "testvault"
2.
On Windows, Obsidian should create a default file "Welcome.md".
3.
On Windows, create new folder "testfolder1", create new file inside
the folder "testfolder1/testfile1.md". Write something into that md file.
4.
On Windows, install remotely save
5.
On Windows, configure webdav (I use infinicloud). DO NOT TOUCH any
other settings!!!! No setting password, not setting auto run, and deletion
destination by default should be system trash.
6.
On Windows, sync
2.
infinicloud website
1. go to infinicloud website, check these are generated: folder
testvault, folder testvault/testfolder1, file
testvault/testfolder1/testfile1.md, file testvault/Welcome.md. The expected
behaviour is that all of them are generated.
3.
iphone
1.
On iphone, create new vault naming "testvault"
2.
On iphone, Obsidian should create a default file "Welcome.md".
3.
On iphone, install remotely save
4.
On iphone, configure webdav (I use infinicloud). DO NOT TOUCH any
other settings!!!! No setting password, not setting auto run, and deletion
destination by default should be system trash.
5.
On iphone, sync
6.
On iphone, check all these are generated in the vault: folder
testfolder1, file testfolder1/testfile1.md, file Welcome.md. The expected
behaviour is that all of them are generated.
4.
windows
1.
On Windows, delete the folder testfolder1
2.
On Windows, sync
3.
On Windows, the sync should fail, because of the deletion protection
4.
On Windows, change the remotely save settings "Abort Sync If
Modifications Above Percentage" to "100% (disable the protection)".
5.
On Windows, sync
6.
The sync should succeed.
5.
infinicloud website
1. go to infinicloud website, *check these are deleted or not: folder
testvault/testfolder1 and file testfolder1/testfile1.md*. The
expected behaviour is that all of them are deleted.
6.
iphone
1.
On iphone, sync
2.
On iphone, the sync should fail, because of the deletion protection
3.
On iphone, change the remotely save settings "Abort Sync If
Modifications Above Percentage" to "100% (disable the protection)".
4.
On iphone, sync
5.
The sync should succeed.
6.
On iphone: *check these are deleted or not: folder
testvault/testfolder1 and file testfolder1/testfile1.md*. The
expected behaviour is that all of them are deleted.
------------------------------
不需要猜测。请*完全按照*以下步骤操作,看看哪一步操作结果和我的描述不一样。请注意,*完全按照*,不要做多了,不要做少了。
1.
Windows
1.
Windows 创建新的库,库名字叫做 testvault
2.
Windows 里 Obsidian 自动在新的库创建了 Welcome.md 文件。
3.
Windows 创建文件夹 testfolder1 ,文件夹里创建文件 testfolder1/testfile1.md,随便写点东西
4.
Windows 安装 remotely save
5.
Windows 设置 webdav。我用
infinicloud。**不要修改其他任何设置!!!**不设置密码,不设置自动运行,删除目的地默认是系统回收站。
6.
Windows 触发同步。
2.
infinicloud 网站
1. 去 infinicloud 网站,检查 testvault文件夹是否有生成,testvault/testfolder1
文件夹是否有生成,testvault/testfolder1/testfile1.md 是否有生成,testvault/Welcome.md
是否有生成。期待行为是所有都生成了。
3.
iphone
1.
打开 iphone Obsidian,创建新的 vault,名字叫 testvault
2.
iphone Obsidian 自动在新的库创建了 Welcome.md 文件。
3.
iphone obsidian 安装 remotely save
4.
iphone obsidian 设置 webdav。我用
infinicloud。**不要修改其他任何设置!!!**不设置密码,不设置自动运行,删除目的地默认是系统回收站。
5.
iphone 触发同步
6.
检查 iphone obsidian 的 valut 内是不是生成了:testfolder1
文件夹,testfolder1/testfile1.md 文件,Welcome.md 文件
4.
windows
1.
windows ,删除 testfolder1 文件夹
2.
windows 触发同步
3.
windows 应该触发了保护,同步失败
4.
windows 的 remotely save 设置,修改删除保护为 100%,也即,去除保护
5.
windows 触发同步
6.
这时候应该同步成功了
5.
infinicloud 网站
1. 去 infinicloud 网站,*检查 testvault/testfolder1 文件夹是不是已经被删除了*,期待行为是被删除了
6.
iphone
1.
iphone 触发同步
2.
iphone 应该触发了保护,同步失败
3.
iphone 的 remotely save 设置,修改删除保护为 100%,也即,去除保护
4.
iphone 触发同步
5.
这时候应该同步成功了
6.
检查 iphone obsidian 的 *vault 内的 testfolder1 是不是被删除了*,期待行为是被删除了。
@2019YKL <https://github.com/2019YKL> *精确按照*这里操作,除了 webdav 换成 s3 之外,其他步骤
*精确按照*每一步进行,看有没有问题。求求了,不这样*精确按照步骤*进行测试的话,我们都是在浪费时间,查不出来的。
—
Reply to this email directly, view it on GitHub
<#611 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BEN5HFJCY36IYUAY4AQL5BTZA5JLLAVCNFSM6AAAAABGLHJUIWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJVGYZDSOBZG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
我多次重新按你的步骤执行了,与预期行为是一致的,但不稳定。 Ipad那边几率出现不删文件,并同步Mac已经删除的文件上去。 我测试了三组,表现不一致。 这次我ipad和mac都录屏下来了。 Mac录屏 iShot_2024-05-06_18.58.11.mp4ipad录屏,头尾两次都同步错误了,中间1:00的时候同步成功了,与预期一致。 iShot_2024-05-06_19.08.33.mp4我的行为就是重复 Mac:创建文件-同步-写入文件-同步-删除文件-同步 Ipad:同步-查看是否写入/删除 |
I fixed a bug around s3 in 0.4.20. May be it's relevant |
问题似乎被成功解决了,多次测试多端写入/删除文件,问题没有再复现。 感谢你的付出~ |
I stress tested on my first 'devTest' vault with the new version .20 and some of the deleted files are still coming back, using OneDrive |
any hints? can you reproduce the error using my steps? |
I just tried on my Android phone, instead of iphone, but I don't get any
Welcome.md when I create 'testvault'.
Den mån 6 maj 2024 kl 18:15 skrev JK2333 ***@***.***>:
… I fixed a bug around s3 in 0.4.20. May be it's relevant
问题似乎被成功解决了,多次测试多端写入/删除文件,问题没有再复现。
感谢你的付出~
—
Reply to this email directly, view it on GitHub
<#611 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BEN5HFME5Q5XC5YYDYOSBIDZA6UB5AVCNFSM6AAAAABGLHJUIWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJWGQYTSNJUGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
never mind you can manually create it and write something (cannot be empty). the spirit is that your vault cannot be empty even after you delete testfolder |
On WebDev now first, instruction 3.6, but on Android: 'On iPhone, check that all these are generated in the vault: folder testfolder1, file testfolder1/testfile1.md, file Welcome.md. The expected behaviour is that all of them are generated.' No, they seem to be blocked by the 50% protection. Expected? |
does your android have any files? but anyways it's not relevant with deletions, so let's disable the protection and let it sync then reenable the protection |
"does your android have any files?" Only my manually created Welcome.md. Everything when as expected. Now I will try with OneDrive. |
With OneDrive it worked as my previous test vid WebDev. BUT when I stood in the root dir of the vault in OneDrive in the browser after step 5.1 the files where still there at first but after a refresh of the page they where gone. Are we dealing with some cache delay and it only get a when dealing with many files? I tried to reproduce but failed. |
the plugin doesn’t have any cache. but onedrive website might have. |
now I seams to have synced an empty file from windows to the Andriod. That should not happend because onedrive didnt accept that. the file where left in the andriod when i synced the erased folder from windows. I then created several empty files in windows but got rejected because they where empty. But the folder "testdir6" that contain them were created. |
really the only thing we both want to find out, is "how to consistently reproduce the error that deleted folders coming back". so i wrote the steps and hopefully any one can find out anything not running as my description. please, please, please, try to strictly follow my steps to find out anything abnormal, any deleted folders coming back. empty files should not be synced, please do not create empty files to make things more complicated. please try to focus on the original problem. |
that's impossible. you must have edited the file somewhere. like what you said, empty files can not be exchanged via onedrive.
that's expected, and they are not relevant to the original problem of the current issue |
please, don't randomly try, don't randomly guess, don't randomly do something not relavent, just try to precisely follow the step and see any thing goes wrong. precisely, step by step, do not do any other thing, no need to do more tests, do not messy up with the database. i really want to help, but i am really unable to guess what happen if the steps are not the same as my guides. please, precisely follow the step, and see anything goes wrong.
|
As mentioned I followed the script with onedrive and it worked and it use to work with a small number of files. The problem with reappearing files has been with syncing changing of a large number of files in the hundreds. I found it very unlikely to recreate the bug with just 1 file and 1 folder because that is not where the bug appears to me. Of course I then try many files when the small file test succeed. And then a empty file appeared from nowhere, related or not. |
4.vi, Fails, due to the protection. Next step? |
ok, let's add a step "4.vi.2 disable the protection" right after 4.vi, and continue the steps |
To be totally clear, the new of disable protection step will not be 4.6.2
but 4.4.2?
Den tis 7 maj 2024 04:05fyears ***@***.***> skrev:
… 4.vi, Fails, due to the protection. Next step?
ok, let's add a step "4.vi.2 disable the protection" right after 4.vi,
and continue the steps
—
Reply to this email directly, view it on GitHub
<#611 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BEN5HFMKVS7HW3U34ROXSVDZBAZFNAVCNFSM6AAAAABGLHJUIWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJXGI2TSOBSGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
in test vault, every time you meet protection, just add an extra step to disable the protection |
I have made the full test and everything went as expected. 7.2 och 7.3 7.4 where skipped because the protection was deactivated in 4.4.2. |
So obviously unfortunately the issue cannot be reproduced in a simple way. :-( :-( we should try some testing to find out the key point to stably trigger the bug... but i have no clues yet |
Maybe trying different number of many files? 10/50/100/200/... Files?
Den tis 7 maj 2024 17:26fyears ***@***.***> skrev:
… So obviously unfortunately the issue cannot be reproduced in a simple way.
:-( :-(
we should try some testing to find out the key point to stably trigger the
bug... but i have no clues yet
—
Reply to this email directly, view it on GitHub
<#611 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BEN5HFMKTYUUQCTPMTFX3VLZBDXBXAVCNFSM6AAAAABGLHJUIWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJYG4YTCNRSGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
请问现在可以开启自动同步的选项了么 |
开呗 |
I follow the instruction with following added step. Error Generated an export, changed the namn on the mapp and synced android and then windows. The non deleted files where of course created in windows. export from andriod. |
two files you uploaded are the same. and what is "mapp"? |
I don't know why the file got there twice... Do you want the windows export
too?
Sorry "mapp" (Swedish) = folder.
Den fre 10 maj 2024 02:03fyears ***@***.***> skrev:
… two files you uploaded are the same.
and what is "mapp"?
—
Reply to this email directly, view it on GitHub
<#611 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BEN5HFITHMX77LI5RG5GRGDZBQFEZAVCNFSM6AAAAABGLHJUIWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBTGYZDIMZQGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Well, there is the export file from windows if you have use of it. |
What happened?
Cannot delete files and folders sometimes (BY SOMETIIMES I MEANT IT HAPPENS A LOT), the deleted file or folders somehow get regenerated.
Deleting a file doesn't delete it on my webdev server
Possible cause: I use this plugin on 3 devices, windows, iphone and ipad
What OS are you using?
Windows, iOS (iPhone, iPad)
What remote cloud services are you using? (Please choose the specified one if it's in the list)
webdav
Version of the plugin
latest
Version of Obsidian
latest
Using password or not
Ensure no sensitive information
The text was updated successfully, but these errors were encountered: