Spatie/dns 1.4 -> 1.5 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @stephanvierkant, thanks for submitting this PR! The reason I was strict with the Spatie DNS version is that I'm hesitant to support / allow a version that has a known bug like this but if it's the version that you're using already in production I would be open to loosening up the requirements with the "use at your own risk" caveat for that version. What do you think? |
|
I haven't tried 1.5, but I'll try if I can reproduce the errors you've found. If this library supports ^1.4, users can choose to use 1.5 or downgrade to 1.4 if they encounter the same problem. |
|
@stephanvierkant released as 4.1.0, as always, thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow spatie/dns 1.5.