fix(text-validation) - pass only values that are strings #12
Conversation
| @@ -46,7 +47,7 @@ | |||
| "dependencies": { | |||
| "lodash": "^4.17.21", | |||
| "randexp": "^0.5.3", | |||
| "yup": "^0.29.1" | |||
| "yup": "^0.30.0" | |||
There was a problem hiding this comment.
todo: Just to make it clear, @gabrielseco and I had a huddle last week: Before we merge this PR, ideally we'd like our internal codebase to also use Yup 0.30 so we don't have Yup twice in our bundles.
Only then we'd merge this PR. WDYT @brennj?
There was a problem hiding this comment.
I have a MR#17451 in our internal codebase.
My plan is to merge this PR and create a release, what do you think @sandrina-p?
After the release I'll update the MR in our internal codebase
There was a problem hiding this comment.
@gabrielseco , I'm answering your question here because Github doesn't support threads is comments detached from code.
I'll create a minor version because we're updating the yup version.
If it was only the fix probably, I'd do a patch.
What do you think @sandrina-p @brennj?
I agree!
|
I'll create a minor version because we're updating the yup version. If it was only the fix probably, I'd do a patch. What do you think @sandrina-p @brennj? |
1. Description
Add a transform function to make the validation work when we're passing numbers or booleans to our text validation.
Screenshots
https://www.loom.com/share/b7a127623c5b41e78d6d3f2d21fcba59?focus_title=1&muted=1&from_recorder=1
Related Resources
2. Type of Change (select one)