feat(description) - Remove extra span in description, extra and statement #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielseco
commented
Jul 5, 2023
gabrielseco
changed the title
|
Let me know if you have time to review this PR this week cc: @sandrina-p @brennj |
Probably not today, but should be good to look at this tomorrow morning~ |
sandrina-p
reviewed
Jul 11, 2023
sandrina-p
reviewed
Sep 18, 2023
|
Applied the suggestions in this PR, I'll go now to dragon and check Sandrina's comments |
|
This is awesome. @gabrielseco whenever you can, lets resolve the conflicts and merge this one. |
|
Resolved conflicts @brennj
|
|
I notice I added a yarn lock, just remove it and added it to gitignore to not commit the same error twice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Description
Remove extra span in the description, extra and statement parameters of the fields
2. How to test this
I've created an internal MR where you can test this.