[JSON Logic] Part 3: Computed string based values #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brennj
force-pushed
the
add-string-based-computedAttrs
branch
from
419491b
to
be9e919
Compare
johnstonbl01
requested changes
Aug 25, 2023
dilvane
reviewed
Aug 29, 2023
sandrina-p
reviewed
Aug 29, 2023
brennj
force-pushed
the
json-logic-add-computedattrs
branch
2 times, most recently
from
6b06f89
to
d2cc213
Compare
brennj
force-pushed
the
add-string-based-computedAttrs
branch
2 times, most recently
from
6c036ad
to
a40da7b
Compare
johnstonbl01
previously approved these changes
Sep 11, 2023
author brennj <john.brennan@remote.com> 1694505093 +0200 committer brennj <john.brennan@remote.com> 1694508319 +0200 Release 0.5.0-beta.0 chore: support barebones computedAttrs chore: fix errors chore: fix mess ups from rebase chore: feedback from PR chore: pass logic down at updateFieldsProperties to prevent bugs feat: JSON Logic skeleton and plumbing setup chore: clean up conditional additions chore: remove const tests chore: remove dupe file chore: remove group array stuff chore: clean up yupschema chore: clean up helpers a small bit chore: remove all error handling for now chore: clean up package-lock chore: more removing stuff chore: clean more chore: support barebones computedAttrs chore: computed string attributes chore: fix tests chore: consistency for curly braces chore: remove unneeded code for now
brennj
force-pushed
the
add-string-based-computedAttrs
branch
from
a40da7b
to
d3f26e2
Compare
sandrina-p
previously approved these changes
Sep 12, 2023
* feat: JSON Logic skeleton and plumbing setup chore: clean up conditional additions chore: remove const tests chore: remove dupe file chore: remove group array stuff chore: clean up yupschema chore: clean up helpers a small bit chore: remove all error handling for now chore: clean up package-lock chore: more removing stuff chore: clean more * chore: support barebones computedAttrs * chore: fix errors * chore: fix mess ups from rebase * chore: feedback from PR * chore: pass logic down at updateFieldsProperties to prevent bugs * Release 0.5.0-dev.20230901130231 * Revert "Release 0.5.0-dev.20230901130231" This reverts commit 55ed296. * feat: JSON Logic skeleton and plumbing setup chore: clean up conditional additions chore: remove const tests chore: remove dupe file chore: remove group array stuff chore: clean up yupschema chore: clean up helpers a small bit chore: remove all error handling for now chore: clean up package-lock chore: more removing stuff chore: clean more * chore: support barebones computedAttrs * chore: computed string attributes * chore: fix tests * chore: consistency for curly braces * chore: remove unneeded code for now * feat: JSON Logic skeleton and plumbing setup chore: clean up conditional additions chore: remove const tests chore: remove dupe file chore: remove group array stuff chore: clean up yupschema chore: clean up helpers a small bit chore: remove all error handling for now chore: clean up package-lock chore: more removing stuff chore: clean more chore: support barebones computedAttrs chore: computed string attributes chore: error handling * chore: fix tests * chore: review errors * chore: fix up code for fixtures * chore: add a bunch of docs to try and make things clearer * chore: add example to docs * chore: higher level console check * chore: use cases to clean up error tests * chore: add more tests for missing vars * chore: use switch statement instead * chore: add code comments why schemas fail * chore: jsdoc tweaks
* feat: JSON Logic skeleton and plumbing setup chore: clean up conditional additions chore: remove const tests chore: remove dupe file chore: remove group array stuff chore: clean up yupschema chore: clean up helpers a small bit chore: remove all error handling for now chore: clean up package-lock chore: more removing stuff chore: clean more * chore: support barebones computedAttrs * chore: fix errors * chore: fix mess ups from rebase * chore: feedback from PR * chore: pass logic down at updateFieldsProperties to prevent bugs * Release 0.5.0-dev.20230901130231 * Revert "Release 0.5.0-dev.20230901130231" This reverts commit 55ed296. * feat: JSON Logic skeleton and plumbing setup chore: clean up conditional additions chore: remove const tests chore: remove dupe file chore: remove group array stuff chore: clean up yupschema chore: clean up helpers a small bit chore: remove all error handling for now chore: clean up package-lock chore: more removing stuff chore: clean more * chore: support barebones computedAttrs * chore: computed string attributes * chore: fix tests * chore: consistency for curly braces * chore: remove unneeded code for now * feat: JSON Logic skeleton and plumbing setup chore: clean up conditional additions chore: remove const tests chore: remove dupe file chore: remove group array stuff chore: clean up yupschema chore: clean up helpers a small bit chore: remove all error handling for now chore: clean up package-lock chore: more removing stuff chore: clean more chore: support barebones computedAttrs chore: computed string attributes chore: error handling * chore: fix tests * chore: review errors * chore: fix up code for fixtures * chore: add a bunch of docs to try and make things clearer * chore: add example to docs * chore: higher level console check * chore: use cases to clean up error tests * chore: add more tests for missing vars * chore: use switch statement instead * chore: add code comments why schemas fail * feat: JSON Logic skeleton and plumbing setup chore: clean up conditional additions chore: remove const tests chore: remove dupe file chore: remove group array stuff chore: clean up yupschema chore: clean up helpers a small bit chore: remove all error handling for now chore: clean up package-lock chore: more removing stuff chore: clean more chore: support barebones computedAttrs chore: error handling feat: add more error handling * chore: changes * chore: add bad operator handling * chore: fix bad naming
This reverts commit 0f24b27.
dilvane
approved these changes
Sep 13, 2023
|
lets goo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Must be merged after #36
Add in x-jsf-logic-computedAttrs (with reference to values defined in x-jsf-logic.computedValues) support.
x-jsf-errorMessage.minimum/maximumtitledescriptionx-jsf.presentation.statement.description