-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added json-schema-form meta schema #6
feat: added json-schema-form meta schema #6
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jguddas, nice to reconnect again, this time about JSON Schemas! 🙌
Thanks a lot for this meta schema, is pretty complete! Left a few notes with a couple examples. Let me know if it makes sense :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are happy with it, we can also think about submitting it to SchemaStore.
@@ -0,0 +1,188 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, @jguddas for your contribution! You were the first one 😄 Approved, merging it now :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last question @jguddas. You called this "hyper" schema, but in my understanding it's a meta schema, right? A "json hyper-schema" refers to an outdated variant of JSON schemas.
Or am I missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are right, meta schema is the right term.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, merged as chore:
because this does not influence the library itself (src/
). Thanks again :)
Pretty nice stuff you made here.
I was missing some type annotations for those custom
x-jsf-
properties, so I wrote some.I hope there isn't already a definition I overlooked?