Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added json-schema-form meta schema #6

Merged

Conversation

jguddas
Copy link
Contributor

@jguddas jguddas commented May 18, 2023

Pretty nice stuff you made here.

I was missing some type annotations for those custom x-jsf- properties, so I wrote some.

I hope there isn't already a definition I overlooked?

Screenshot of editor showing an error message when hovering x-jsf-presentation.inputType due to it being set to an unsupported type, in this case textarea.

@vercel
Copy link

vercel bot commented May 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
json-schema-form ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2023 3:31pm

Copy link
Collaborator

@sandrina-p sandrina-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jguddas, nice to reconnect again, this time about JSON Schemas! 🙌

Thanks a lot for this meta schema, is pretty complete! Left a few notes with a couple examples. Let me know if it makes sense :)

json-schema-form.schema.json Show resolved Hide resolved
json-schema-form.schema.json Outdated Show resolved Hide resolved
json-schema-form.schema.json Outdated Show resolved Hide resolved
json-schema-form.schema.json Outdated Show resolved Hide resolved
json-schema-form.schema.json Show resolved Hide resolved
Copy link
Contributor Author

@jguddas jguddas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are happy with it, we can also think about submitting it to SchemaStore.

json-schema-form.schema.json Show resolved Hide resolved
json-schema-form.schema.json Show resolved Hide resolved
@jguddas jguddas marked this pull request as ready for review May 19, 2023 12:33
@@ -0,0 +1,188 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @jguddas for your contribution! You were the first one 😄 Approved, merging it now :)

Copy link
Collaborator

@sandrina-p sandrina-p May 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last question @jguddas. You called this "hyper" schema, but in my understanding it's a meta schema, right? A "json hyper-schema" refers to an outdated variant of JSON schemas.

Or am I missing something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are right, meta schema is the right term.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, merged as chore: because this does not influence the library itself (src/). Thanks again :)

@jguddas jguddas changed the title feat: added json-schema-form hyper schema feat: added json-schema-form meta schema May 19, 2023
@sandrina-p sandrina-p merged commit 414a5fe into remoteoss:main May 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants