This repository has been archived by the owner on Jan 5, 2023. It is now read-only.
Prepare Precompilation #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
while you borrow the CI setup from wasmex, can I ask you to borrow everything, please? :D (including lints, tests, compatibility tests) |
added 2 commits
May 17, 2022 13:58
Gets everything ready to use precompiled NIFs based on https://github.com/tessi/wasmex
filipecabaco
force-pushed
the
precompiled-binary
branch
from
b15a6f9
to
2e50b73
Compare
filipecabaco
force-pushed
the
precompiled-binary
branch
from
f4dcad6
to
210252b
Compare
filipecabaco
force-pushed
the
precompiled-binary
branch
from
ff6ab75
to
f369ca2
Compare
tessi
force-pushed
the
precompiled-binary
branch
3 times, most recently
from
8eb798c
to
e41799d
Compare
tessi
reviewed
May 18, 2022
tessi
reviewed
May 18, 2022
Comment on lines
+56
to
+60
| arm-unknown-linux-*) sudo apt-get -y update ; sudo apt-get -y install gcc-arm-linux-gnueabihf; sudo dpkg --add-architecture armhf; sudo apt-get update || true; sudo apt-get -y install libpoppler-glib-dev:armhf libpoppler-dev:armhf libcairo2-dev:armhf libglib2.0-dev:armhf; export PKG_CONFIG_LIBDIR=/usr/lib/arm-linux-gnueabihf/pkgconfig;; | ||
| aarch64-unknown-linux-gnu) sudo apt-get -y update ; sudo apt-get -y install gcc-aarch64-linux-gnu; sudo dpkg --add-architecture arm64; sudo apt-get update || true; sudo apt-get -y install libpoppler-glib-dev:arm64 libpoppler-dev:arm64 libcairo2-dev:arm64 libglib2.0-dev:arm64;; | ||
| aarch64-apple-darwin) NONINTERACTIVE=1 /bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh)"; brew install gnu-tar poppler; sudo ln -s $(brew --prefix)/opt/gnu-tar/libexec/gnubin/tar /usr/local/bin/tar;; | ||
| x86_64-apple-darwin) NONINTERACTIVE=1 /bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh)"; brew install poppler;; | ||
| *) sudo apt-get -y update ; sudo apt-get -y install libpoppler-glib-dev libpoppler-dev libcairo2-dev libglib2.0-dev |
There was a problem hiding this comment.
This is still somewhat messy and covers archs we don't currently support. But it "documents" some of the fixes we attempted. not sure if we should leave it in case we're extending arch support or not
tessi
reviewed
May 18, 2022
tessi
reviewed
May 18, 2022
tessi
reviewed
May 18, 2022
tessi
reviewed
May 18, 2022
|
maybe not for this PR, but we still need a license 🤔 |
filipecabaco
force-pushed
the
precompiled-binary
branch
from
66392cf
to
84359ee
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets everything ready to use precompiled NIFs based on https://github.com/tessi/wasmex