Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run ESLint on Travis #1061

Closed
raucao opened this issue Oct 29, 2017 · 1 comment
Closed

Run ESLint on Travis #1061

raucao opened this issue Oct 29, 2017 · 1 comment
Assignees
@raucao
Labels
dev environment

Comments

@raucao
Copy link
Member

raucao commented Oct 29, 2017

Linting should be run both locally and on CI and errors should make the tests red.

Needs fixing of some syntax issue first, so it's not red from the start.
@raucao raucao changed the title Run JSHint in npm-test script Run eslint in npm-test script Nov 2, 2017
@raucao raucao self-assigned this Nov 3, 2017
@raucao raucao added in progress and removed ready labels Nov 3, 2017
@raucao raucao changed the title Run eslint in npm-test script Run eslint on Travis Nov 3, 2017
@raucao raucao changed the title Run eslint on Travis Run ESLint on Travis Nov 3, 2017
@raucao
Copy link
Member Author

raucao commented Nov 3, 2017 •
edited

Added npm run lint for running locally, and edited the Travis config to run that command.

(Original commit that introduced it contained a typo, fixed in the ESLint branch/PR already.)

@raucao raucao closed this as completed in db0dd0a Nov 3, 2017
@raucao raucao removed the in progress label Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raucao raucao

Labels
dev environment
Milestone
No milestone
Development

No branches or pull requests
1 participant
@raucao