Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong backend value when not connected on app start #1091

Open
galfert opened this issue Nov 7, 2017 · 4 comments
Open

Wrong backend value when not connected on app start #1091

galfert opened this issue Nov 7, 2017 · 4 comments
Labels

Comments

@galfert
Copy link
Member

galfert commented Nov 7, 2017

When no storage is connected yet, remoteStorage.backend already has the value "remotestorage".

But when connecting a storage and then disconnecting, remoteStorage.backend is undefined.

The value should be undefined in the beginning as well.

@galfert galfert changed the title Wrong backend value when not connected Wrong backend value when not connected on app start Nov 7, 2017
@raucao
Copy link
Member

raucao commented Nov 7, 2017

It's not really a bug, is it? This is not meant to indicate connection state, and the default is remotestorage after all.

@galfert
Copy link
Member Author

galfert commented Nov 7, 2017

But it's inconsistent from when you disconnect. So I would count that as a bug.

@galfert
Copy link
Member Author

galfert commented Nov 7, 2017

I think we should also mention this property in the documentation for Dropbox/Google Drive.

@raucao
Copy link
Member

raucao commented Nov 7, 2017

But it's inconsistent from when you disconnect. So I would count that as a bug.

My point was that the bug could just as well be that it's undefined after disconnecting. In fact, undefined is worse than a default value imo, because it's usually used for things that are literally not defined, instead of e.g. a null value for something that is defined, but has no value.

@raucao raucao removed the ready label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants