Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty files leads to infinite fetching during sync process #903

Open
untitaker opened this issue Oct 15, 2015 · 5 comments
Open

Empty files leads to infinite fetching during sync process #903

untitaker opened this issue Oct 15, 2015 · 5 comments
Assignees
@untitaker
Labels
bug

Comments

@untitaker
Copy link
Member

This has the same root cause as #187

I wonder whether we should introduce a node type, with methods that do the rigorous checking for us. Currently the code of sync.js is littered with typeof-checks, unfortunately only partially.
@untitaker untitaker added the bug label Oct 15, 2015
@raucao
Copy link
Member

raucao commented Oct 16, 2015

Good idea.

@untitaker
Copy link
Member Author

Where would I define such a type?

@raucao
Copy link
Member

raucao commented Oct 16, 2015

It's a fairly complex topic, as you also have to implement it with the caching in mind.

@untitaker
Copy link
Member Author

It would only replace the {...} construction I see in makeNode. It's not even a real design change?

@raucao
Copy link
Member

raucao commented Oct 16, 2015

Oh, ok. Haven't looked into it specifically. Just explore on your own.

@untitaker untitaker self-assigned this Oct 16, 2015
@untitaker untitaker mentioned this issue Oct 19, 2015
Closed
@raucao raucao added the ready label Mar 19, 2016
@raucao raucao removed the ready label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@untitaker untitaker

Labels
bug
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raucao @untitaker