Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for node version checking #117

Merged
merged 6 commits into from
Feb 17, 2021
Merged

Conversation

Iamshankhadeep
Copy link
Contributor

fixes #108.

@Iamshankhadeep Iamshankhadeep changed the title Added support for node version checking WIP: Added support for node version checking Feb 17, 2021
@JonnyBurger
Copy link
Member

Thanks! This works!
I would still like to perfect it a little more:

  • Let's make the check into a function and call it as the first thing in packages/cli/src/index.tsx. Benefit: We don't need to load ts-node twice which is quite slow. Also the check will run before you start the CLI and not after install, this is a little bit better because the node version can change inbetween.

  • By adding to the engines field in package.json, it will hard-fail when your node version is too low. So people will probably not even see the warning we put because NPM is failing. Let's inline the requirement so it's just a warning and not an error (for now)

@Iamshankhadeep Iamshankhadeep changed the title WIP: Added support for node version checking Added support for node version checking Feb 17, 2021
@JonnyBurger JonnyBurger merged commit d687911 into main Feb 17, 2021
@JonnyBurger JonnyBurger deleted the minimum-node-support branch February 17, 2021 22:50
@JonnyBurger
Copy link
Member

Thanks a lot! 💙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce minimum node version
2 participants