Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! 馃憢馃徑
The current implementation, using
div
s, prevents better keyboard navigation - we can't tab through the list of compositions or interact with the buttons without using the arrow keys.This PR improves keyboard navigation by using
button
tags were applicable and adding thehref
attribute to thea
tags of compositions.While implementing these changes, I wondered if it'd interesting to try and add
react-router-dom
or something similar to implement actual navigation in React.