Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve keyboard navigation #125

Merged

Conversation

arthurdenner
Copy link
Contributor

Hi! 馃憢馃徑

The current implementation, using divs, prevents better keyboard navigation - we can't tab through the list of compositions or interact with the buttons without using the arrow keys.

This PR improves keyboard navigation by using button tags were applicable and adding the href attribute to the a tags of compositions.

While implementing these changes, I wondered if it'd interesting to try and add react-router-dom or something similar to implement actual navigation in React.

@Iamshankhadeep
Copy link
Contributor

Iamshankhadeep commented Feb 20, 2021

I must say this is a nice feature improvement. Let @JonnyBurger review it. Thanks for the PR.

@JonnyBurger
Copy link
Member

Wow this works really well! Thanks a lot for this quality PR! 馃挋
I'll make sure to shout you out in the next blog post.
And also I'll probably use it as a reference when I struggle in the future with adding keyboard controls 馃榿

@JonnyBurger JonnyBurger merged commit b3bfdf8 into remotion-dev:main Feb 20, 2021
@arthurdenner arthurdenner deleted the feat/improve-navigation-keyboard branch February 20, 2021 11:00
@arthurdenner
Copy link
Contributor Author

Thank you for this awesome project and kind words!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants