Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added option to customise play pause and fullscreen icons #1403

Merged
merged 9 commits into from
Oct 17, 2022

Conversation

uragirii
Copy link
Contributor

@uragirii uragirii commented Oct 14, 2022

Fixes #740.

Adds props to cutomise Play pause buttons and fullscreen icons.

  • Add props
  • Add documentation
  • Fix CI build error

IssueHunt Summary

Referenced issues

This pull request has been submitted to:


@vercel
Copy link

vercel bot commented Oct 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
remotion ✅ Ready (Inspect) Visit Preview Oct 17, 2022 at 1:12PM (UTC)

@JonnyBurger
Copy link
Member

It works excellently! 🙌
Thanks a lot for this PR 💙 Really appreciated!

How long do you estimate you spent on it?

@JonnyBurger JonnyBurger merged commit 71ac49e into remotion-dev:main Oct 17, 2022
@uragirii
Copy link
Contributor Author

uragirii commented Oct 17, 2022

How long do you estimate you spent on it?

~30 mins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to customize the Player UI more, e.g. the Play button
2 participants