Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes of Player #363

Merged
merged 2 commits into from
May 11, 2021
Merged

Fixes of Player #363

merged 2 commits into from
May 11, 2021

Conversation

Iamshankhadeep
Copy link
Contributor

Fixes #346

@Iamshankhadeep Iamshankhadeep marked this pull request as draft May 10, 2021 08:48
@Iamshankhadeep Iamshankhadeep marked this pull request as ready for review May 10, 2021 15:41
@JonnyBurger JonnyBurger merged commit 41eda92 into main May 11, 2021
@JonnyBurger
Copy link
Member

Thanks! I tried to make our own fullscreen icon so we can make it pixel perfectly align with the pause icon in the future. We'll see how that goes haha. Maybe trying to be to perfectionistic... anyway thanks for the PR! 🙌

@JonnyBurger JonnyBurger deleted the player-fix branch May 28, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonnyBurger JonnyBurger JonnyBurger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix fullscreen icon in <Player />
2 participants
@Iamshankhadeep @JonnyBurger