Add parameter maxLength to transcribe #3703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe/Alipay. |
|
This is perfect! Thanks a lot! |
JonnyBurger
approved these changes
Apr 11, 2024
|
Thanks @JonnyBurger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3688
This PR adds the possibility to configure the
max-lengthparameter that is passed to whisper.cpp (previously hard coded to 1).The function
transcribenow also accepts a parametermaxLength.The parameter can only be also be set to null, to use
whisper.cpp's default token grouping (useful for generating a movie-style transcription).Backwards compatibility
The function is backward compatible. If
maxLengthis not provided, a default value of 1 is used (same behaviour as before)Note
Since
convertToCaptionsgroups the transcription-items and not the tokens, the parametermaxLengthcan now only be used whentokenLevelTimestampsis set false.Question: Would
tokensPerTranscriptionItembe a batter/more accurate name?/claim 3688