Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remotion: Several buffering state fixes #3853

Merged
merged 3 commits into from
May 10, 2024
Merged

remotion: Several buffering state fixes #3853

merged 3 commits into from
May 10, 2024

Conversation

JonnyBurger
Copy link
Member

Bugs we had before:

  • Resume and buffering callbacks would fire twice
  • In Studio, buffering indicator would only show once
  • delay was set to 0 by default instead of 300 in the Studio
  • Improper cleanup in listeners leading to unexpected behaviors

Copy link

vercel bot commented May 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bugs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 8:21am
remotion ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 8:21am

@JonnyBurger JonnyBurger merged commit f5a2171 into main May 10, 2024
13 checks passed
@JonnyBurger JonnyBurger deleted the fix-buffer-state branch May 10, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant