Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get-environment.ts #460

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Update get-environment.ts #460

merged 1 commit into from
Jun 15, 2021

Conversation

JonnyBurger
Copy link
Member

In ejected CRA apps, we cannot expect that process.env.NODE_ENV is set. Therefore we fall back to development and don't fail hard.

While rendering, we set it explicitly always.

@JonnyBurger JonnyBurger merged commit 0c9a62c into main Jun 15, 2021
@JonnyBurger JonnyBurger deleted the dev-environment branch June 15, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant