Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Relative Framenumber showing on each Timeline item #468

Merged
merged 20 commits into from
Jun 19, 2021

Conversation

ahgsql
Copy link
Contributor

@ahgsql ahgsql commented Jun 18, 2021

Hi, this is my first pr, When editing components, i need to see frame number relative to current sequence and with small research, be able to do that. So All Timeline Sequences will show their frame number based on their "from" prop, if timeline cursor aboves it.

@JonnyBurger
Copy link
Member

Hi @ahgsql! Awesome PR, thanks a lot! I intend to merge it, it's a nice feature!

If you have time, can you restore all the package-lock.json files to the original ones? They shouldn't change. Probably it's because we used npm 7 to generate them and you used npm 6 to install it, it's a bit annoying...

@JonnyBurger
Copy link
Member

I did it now and made some more changes - I moved it to the left side and am rendering the time in human format, e.g. 0:00:01.34, plus added a title label for explanation. Also reverted the timeline tracks style - it was unclear why it was changed in this PR.

Thanks a lot for the idea and the PR! 🙌

@JonnyBurger JonnyBurger merged commit 861d80e into remotion-dev:main Jun 19, 2021
@ahgsql
Copy link
Contributor Author

ahgsql commented Jun 21, 2021

I did it now and made some more changes - I moved it to the left side and am rendering the time in human format, e.g. 0:00:01.34, plus added a title label for explanation. Also reverted the timeline tracks style - it was unclear why it was changed in this PR.

Thanks a lot for the idea and the PR! 🙌

sorry for lockfiles and gradient changes, i forgot it to revert, was just experimenting. And moving to left pane was good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants