Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make durationInFrames optional #621



Copy link

@khalid283 khalid283 commented Oct 2, 2021

Resolve #526
Screenshot 2021-10-02 at 4 16 56 PM

There are two references of durationInFrames={Infinity} in the test that I have not removed, letting you decide.

Check locally by making changes in the example project and run docs to check doc changes. Also, eslint rules.

IssueHunt Summary

Referenced issues

This pull request has been submitted to:

Updated the Sequence to make durationInFrames and by default value will be Infinity.
Removed the test for missing duration, since durationInFrames is optional it will no longer throw error.
Updated examples in docs to remove reference of durationInFrames, since it no longer required
Updated using-audio and use-current-frame doc to remove reference of durationInFrames
Updated doc of Sequence component to remove reference of durationInFrames and updated optional prop
Updated the durationInFrames prop description
Updated the doc to remove reference of durationInFrames
Added rule for duration-in-frame and included test also
@khalid283 khalid283 marked this pull request as ready for review October 2, 2021 10:53
Copy link

It is fantastic! 👏

I did some testing and it worked super well 😎 ESLint rule is super cool too! Thanks a lot 🥳

JonnyBurger previously approved these changes Oct 2, 2021
Copy link
Contributor Author

Will make other PR in the template repo.

Copy link

That would be fantastic @khalid283!
I am in the process of merging and releasing.

@JonnyBurger JonnyBurger merged commit c1ac137 into remotion-dev:main Oct 2, 2021
Copy link

All templates are up to date and a new version was released, thanks a lot for your contribution @khalid283! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Proposal: Allow to omit durationInFrames={Infinity} for sequence
2 participants