Make durationInFrames optional #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the Sequence to make durationInFrames and by default value will be Infinity.
Removed the test for missing duration, since durationInFrames is optional it will no longer throw error.
Updated examples in docs to remove reference of durationInFrames, since it no longer required
Updated using-audio and use-current-frame doc to remove reference of durationInFrames
Updated doc of Sequence component to remove reference of durationInFrames and updated optional prop
Updated the durationInFrames prop description
Updated the doc to remove reference of durationInFrames
Added rule for duration-in-frame and included test also
|
It is fantastic! 👏 I did some testing and it worked super well 😎 ESLint rule is super cool too! Thanks a lot 🥳 |
JonnyBurger
previously approved these changes
Oct 2, 2021
|
Will make other PR in the template repo. |
|
That would be fantastic @khalid283! |
JonnyBurger
approved these changes
Oct 2, 2021
khalid283
commented
Oct 2, 2021
packages/eslint-plugin/src/tests/no-duration-frames-infinity.test.ts
Outdated
Show resolved
Hide resolved
|
All templates are up to date and a new version was released, thanks a lot for your contribution @khalid283! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #526
There are two references of
durationInFrames={Infinity}in the test that I have not removed, letting you decide.Check locally by making changes in the example project and run docs to check doc changes. Also, eslint rules.
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
durationInFrames={Infinity}for sequence