Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leading zero padding on output filenames #91

Merged
merged 2 commits into from
Feb 14, 2021

Conversation

zackdotcomputer
Copy link
Contributor

Resolves #89 by adding leading zero padding the index number on saved filenames so that all index numbers in a batch are the same string length. This fixes ls ordering and * glob ordering of the collected files.

Also switches ffmpeg stitcher to using * glob selection rather than %d selection to remain compatible with that new numbering.

@JonnyBurger JonnyBurger added this to In progress in Roadmap Feb 14, 2021
@JonnyBurger JonnyBurger merged commit ca2e3e4 into remotion-dev:main Feb 14, 2021
@JonnyBurger
Copy link
Member

Works wonderfully! Thanks a lot for the PR 💙

This will be in the next release, likely coming out tomorrow, or you can upgrade to the prerelease right now, hope the little roadbump didn't slow you down too much!

 - @remotion/bundler@1.3.0-alpha.ca2e3e45
 - @remotion/cli@1.3.0-alpha.ca2e3e45
 - remotion@1.3.0-alpha.ca2e3e45
 - create-video@1.3.0-alpha.ca2e3e45
 - @remotion/eslint-config@1.3.0-alpha.ca2e3e45
 - @remotion/eslint-plugin@1.3.0-alpha.ca2e3e45
 - @remotion/renderer@1.3.0-alpha.ca2e3e45

@zackdotcomputer
Copy link
Contributor Author

👍 not a problem at all. I really like the tool and am happy to help make it better.

@zackdotcomputer zackdotcomputer deleted the zero-padding-filenames branch February 14, 2021 19:30
@JonnyBurger JonnyBurger moved this from In progress to Done in Roadmap Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

PNG output - zero-pad output indices
3 participants