Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to eslint 9 (remotion repo - #4016) #16

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

abhishek818
Copy link
Contributor

@abhishek818 abhishek818 commented Jun 26, 2024

Related PR.

Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
remotion-helloworld ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2024 1:06pm

Copy link

netlify bot commented Jun 26, 2024

Deploy Preview for singular-halva-dbec54 ready!

Name Link
🔨 Latest commit ab2210e
🔍 Latest deploy log https://app.netlify.com/sites/singular-halva-dbec54/deploys/667c1211c653f400084e5aa6
😎 Deploy Preview https://deploy-preview-16--singular-halva-dbec54.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@abhishek818
Copy link
Contributor Author

abhishek818 commented Jun 26, 2024

@JonnyBurger Up for review.

the current error is

PS C:\Users\Abhishek\Desktop\open_source\template-helloworld> npm test

> remotion-template@1.0.0 test
> eslint src && tsc


Oops! Something went wrong! :(

ESLint: 9.5.0

Error: Cannot read config file: C:\Users\Abhishek\Desktop\open_source\template-helloworld\node_modules\@remotion\eslint-config\dist\index.js
Error: Failed to patch ESLint because the calling module was not recognized.
If you are using a newer ESLint version that may be unsupported, please create a GitHub issue:
https://github.com/microsoft/rushstack/issues
Referenced from: 
    at allowESLintShareableConfig (C:\Users\Abhishek\Desktop\open_source\template-helloworld\node_modules\@remotion\eslint-config\dist\patch-eslint.js:157:23)
    at Object.<anonymous> (C:\Users\Abhishek\Desktop\open_source\template-helloworld\node_modules\@remotion\eslint-config\dist\index.js:532:47)
    at Module._compile (node:internal/modules/cjs/loader:1358:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1416:10)
    at Module.load (node:internal/modules/cjs/loader:1208:32)
    at Module._load (node:internal/modules/cjs/loader:1024:12)
    at Module.require (node:internal/modules/cjs/loader:1233:19)
    at require (node:internal/modules/helpers:179:18)
    at module.exports (C:\Users\Abhishek\Desktop\open_source\template-helloworld\node_modules\import-fresh\index.js:32:32)
    at loadJSConfigFile (file:///C:/Users/Abhishek/Desktop/open_source/template-helloworld/node_modules/@eslint/eslintrc/lib/config-array-factory.js:237:16)
    

Above error refers to remotion/eslint-config packge, have pushed a fix here, Will need to test again when eslint-config package gets published with that fix.

Seems we need to update eslint version and run npx @eslint/migrate-config .eslintrc in remotion/eslint-plugin package too.

@abhishek818
Copy link
Contributor Author

/claim #4016

@JonnyBurger
Copy link
Member

Works well! Awesome, thanks a lot @abhishek818 😊

@JonnyBurger JonnyBurger merged commit 4e3358f into remotion-dev:main Jun 26, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants