fix: names in lavaan_extract #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amazing, thank you for signaling this bug and for fixing it in this PR! The tests are only failing because the tests snapshots have changed following this change. Do you know how to update snapshots from your fork? If so could you please update the snapshots and then I will merge your PR. Thanks! |
|
No problem! I tried updating the snapshots. I can't see the tests on the CI, but it passed on my computer just now. |
|
Still failing on mac (and windows) apparently, which is strange because I updated the snapshots on my mac and the tests passed locally. any ideas? |
rempsyc
reviewed
Jun 19, 2024
|
Thank you for your contribution @ethanbass ! 😄 Hope you enjoy the package 😊 |
|
Thanks, it seems really helpful so far! |
|
All tests are passing now 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I think the
lavaan_extractfunction only works as intended currently if you provide a list of replacement symbols rather than just one. Otherwise, the function overwrites all the paths in column one with whatever's in the first row as you can see in this screenshot from the vignette:The current version works correctly only if you provide a vector of replacement characters, e.g.,
lavaanExtra::lavaan_defined(fit,nice_table = TRUE, underscores_to_symbol = rep("->",4))With my fix, it displays correctly with the default syntax:
lavaanExtra::lavaan_defined(fit,nice_table = TRUE, underscores_to_symbol = "->")Thanks!
Ethan