Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an option to crash the remultExpress server if ensureSchema fails #297

Closed
sefininio opened this issue Nov 26, 2023 · 5 comments
Closed

Comments

@sefininio
Copy link

Is your feature request related to a problem? Please describe.
When deploying to GCP, pods can't be loaded with dependencies on other pods - so the server might load before the DB instance and ensureSchema will fail silently. This scenario is better treated with exit 1 so the pod will restart itself until success.

Describe the solution you'd like
Add an optional option to remultExpress (defaults to false) that if true, will crash the server when ensureScheme fails.

@noam-honig
Copy link
Collaborator

checkout remult@0.23.0-exp.29

@noam-honig
Copy link
Collaborator

@sefininio can you check it out and let me know if it's ok?

@sefininio
Copy link
Author

Oh, I completely missed the previous comment (on the same freaking day! - amazing)
I'll try to bring up an env where this can be tested. Thanks!

@sefininio
Copy link
Author

Yes, that works!
I now get failed ensure schema of players Error: connect ECONNREFUSED which is awesome , thanks man!

@noam-honig
Copy link
Collaborator

Great - closing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants