Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[low] Comment header #9

Open
BtM909 opened this issue Sep 3, 2015 · 3 comments
Open

[low] Comment header #9

BtM909 opened this issue Sep 3, 2015 · 3 comments

Comments

@BtM909
Copy link

BtM909 commented Sep 3, 2015

Would it be possible to add a comment header to the build version of bind.js (or even include this to the dev version as well)?

I've taken the liberty to write a sample for you :)

dist version

/*! bind v0.40 | (c) 2013, 2015 Remy Sharp | rem.mit-license.org */

dev version

/*!
 * bind.js v0.4.0
 * https://github.com/remy/bind/
 *
 * Copyright 2013, 2015 Remy Sharp
 * Released under the MIT license
 * http://rem.mit-license.org/
 */
@remy
Copy link
Owner

remy commented Sep 3, 2015

Happy to add to the dist version (via this https://github.com/remy/bind.js/blob/master/package.json#L10 build) but the dev version won't/can't contain the version string since the source isn't generated.

@BtM909
Copy link
Author

BtM909 commented Sep 3, 2015

Ah ok, so would you prefer to just add this to the dist version or add them to both and omit the version for the dev version?

@remy
Copy link
Owner

remy commented Sep 3, 2015

Happy to add to both, but just omit the version string from the dev
version. It should be straight forward to do a perl regexp replace to get
the version inserted into the right position.

On Thu, 3 Sep 2015 at 11:33 BtM909 notifications@github.com wrote:

Ah ok, so would you prefer to just add this to the dist version or add
them to both and omit the version for the dev version?


Reply to this email directly or view it on GitHub
#9 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants