Using encodeURI breaks some URLs

[codeclown]

Background:

Since PR #103 URLs are passed through encodeURI in get.js:

inliner/lib/get.js

Line 74 in df3619f

request(encodeURI(url), settings, function response(error, res, body) {

Problem:

This can result in 404s for otherwise working URLs. Example:

<img src="http://example.com/img/ExampleImage%20Space.png" />

Passing it through encodeURI turns the encoded space character %20 into %2520:

encodeURI('http://example.com/img/ExampleImage%20Space.png')
"http://example.com/img/ExampleImage%2520Space.png"

Which breaks the URL, and now we get a 404 for the image when trying to inline it.

[codeclown]

PR made: #192

---

Anyone bumping into this issue could use my branch for the time being:

yarn add https://github.com/codeclown/inliner.git#encoded-space