Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrying on 503 errors #193

Open
adamkerz opened this issue Jan 4, 2019 · 3 comments
Open

Retrying on 503 errors #193

adamkerz opened this issue Jan 4, 2019 · 3 comments

Comments

@adamkerz
Copy link

adamkerz commented Jan 4, 2019

Some slow/low powered servers throw lots of 503 errors when trying to scrape a bunch of images at once. It would be nice for Inliner to either retry on 503 or for me to set an option to limit the number of requests being made at once.

@adamkerz
Copy link
Author

adamkerz commented Jan 4, 2019

I worked around the issue by "saving as" "webpage complete" with chrome, then inlining that file.

Still, a way to limit the number of synchronous requests would be nice.

@remy
Copy link
Owner

remy commented Jan 4, 2019

Makes sense - I'd take a PR if you want to take a shot.

@adamkerz
Copy link
Author

Sorry remy, unfortunately it's beyond my time abilities at the moment - my JS isn't that strong and the Stackoverflow page that I found made it look complicated. Perhaps it would be simpler to make the code only make a single request at a time, but still, I just don't have the time and I found a workaround, as detailed above. Thanks for the great tool, though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants