fix: don't try to parse non-text

wm was trying to DOM parse an mp3 file which would blow up Fixes #24
remy · May 3, 2020 · 73dfb61 · 73dfb61
1 parent 37e3bba
commit 73dfb61
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/endpoint.js b/lib/endpoint.js
@@ -91,9 +91,15 @@ function getWebmentionUrl(opts, callback) {
         return;
       }
     }
+
+    // don't try to parse non-text (i.e. mp3s!)
+    if (!res.headers['content-type'].startsWith('text/')) {
+      callback();
+      return;
+    }
     var buf = '';
 
-    res.on('data', chunk => (buf += chunk));
+    res.on('data', chunk => (buf += chunk.toString()));
     res.on('end', () => {
       callback(null, findEndpoints(buf.toString(), res.responseUrl));
     });

diff --git a/lib/ignored-endpoints.js b/lib/ignored-endpoints.js
@@ -9,6 +9,7 @@ e.g. .github.com will match both github.com and gist.github.com
 
 module.exports = `
 .amazon.com
+.amazonaws.com
 .cloudfront.net
 .facebook.com
 .flickr.com