Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better command line parsing wrt benchmark execution #233

Open
ceresek opened this issue Nov 11, 2020 · 0 comments
Open

Better command line parsing wrt benchmark execution #233

ceresek opened this issue Nov 11, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@ceresek
Copy link
Collaborator

ceresek commented Nov 11, 2020

The current command line parsing code does not warn when multiple execution policies (--repetitions <count> and --run-seconds <seconds> and --operation-run-seconds <seconds>) are specified on the command line, and simply uses the last (?) one for everything.

Ideally, we should use the policies in a logical or, so that if any tells the harness to stop, it stops. (In practice, we needed a combination of max iteration count and max time, which could be done by a plugin, but having logical or could be better ?).

@ceresek ceresek added the enhancement New feature or request label Nov 11, 2020
@lbulej lbulej self-assigned this Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants