Update scala3-compiler to version 3.3.1 and migrate scala-dotty to Scala 3 #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should avoid issues with using Scala 3 code (scala3-compiler_3) from Scala 2. This broke with version 3.1.3 of scala3-compiler when Scala 2.13 compiler start to complain about "Unsupported Scala 3 union in parameter value" (3.1.2 was the last to work). For compatibility with JDK21, we need fixes to Tasty reader which was broken by changes to javac in JDK21-b21 (see JDK-8292275), which only made it into version 3.3.1-RC1. Using reflection would probably fix the problem, as might a Java-based bridge method, but switching to Scala 3 seems to work as well and paves the way to introducing more Scala 3 benchmarks in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should avoid issues with using Scala 3 code (scala3-compiler_3) from Scala 2. This broke with version 3.1.3 of scala3-compiler when Scala 2.13 compiler started to complain about "Unsupported Scala 3 union in parameter value" (3.1.2 was the last to work).
For compatibility with JDK21 (see #384), we need fixes to Tasty reader which was broken by changes to javac in JDK21-b21 (see JDK-8292275), which only made it into version 3.3.1-RC1.
Using reflection would probably fix the problem, as might a Java-based bridge method, but switching to Scala 3 seems to work as well and paves the way to introducing more Scala 3 benchmarks in the future.
Fixes #384.