Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If installed, prefer the ueberdosis/pandoc package over ryakad/pandoc-php #108

Merged
merged 4 commits into from Aug 25, 2023

Conversation

extracts
Copy link
Contributor

This pull request presents a possible solution for #107, i.e. it will cause the ueberdosis/pandoc package to be preferred over ryakad/pandoc-php if it is installed.

@extracts extracts changed the title If installed, prefer the ueberdosis/pandoc package over ryakad/pandoc-php If installed, prefer the ueberdosis/pandoc package over ryakad/pandoc-php Jul 13, 2023
@extracts extracts changed the title If installed, prefer the ueberdosis/pandoc package over ryakad/pandoc-php If installed, prefer the ueberdosis/pandoc package over ryakad/pandoc-php Jul 13, 2023
…w only happens once, and throws an exception in case requirements aren't met

(cherry picked from commit 82d8327)
…e to ryakad/pandoc-php

(cherry picked from commit fdd7a6a)
@renanbr
Copy link
Owner

renanbr commented Aug 21, 2023

@extracts I pushed 2a90df5 with CI, CS and PHPStan fixes.

Let me know if the current code still work for your use case.

@extracts
Copy link
Contributor Author

@renanbr Thanks for the fixes, I've tested the changes in this pull request with our software and can report that it all works fine.

@renanbr renanbr merged commit d02d242 into renanbr:main Aug 25, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants